0001703: Malformed XML crashes XMLRPC

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001703

Anope Stable (2.0.x series)

[All Projects] General

public

2017-04-14 11:38

2017-07-25 01:38

Reporter

Absolver

Assigned To

Adam

Priority

normal

Severity

crash

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Anope 2.0.5

Ubuntu 14.04 LTS

OS Version

Summary

0001703: Malformed XML crashes XMLRPC

Description

Sending malformed XML to the XMLRPC handler crashes Anope.

Steps To Reproduce

1) Set up Anope 2.0.5 with XMLRPC enabled
2) Verify that XMLRPC is up and running
3) Send the following XML to XMLRPC:
<?xml version="1.0" encoding="iso-8859-1"?>
<methodCall>
    <methodName>checkAuthentication</methodName>
    <params>
        <param>
            <value>
                <string>randomuser</string>
                <string>randompassword</string>
            </value>
        </param>
    </params>
</methodCall

(Note the missing closing > in the methodCall end tag)

Additional Information

Debug log information from sending the malformed XML:
Apr 14 12:33:04.147078 2017] Accepted connection 10 from 84.202.160.14
[Apr 14 12:33:04.335267 2017] m_httpd: Serving page /xmlrpc to 84.202.160.14
[Apr 14 12:33:04.335323 2017] m_xmlrpc: Tag name: ?xml version="1.0" encoding="iso-8859-1"?, data:

[Apr 14 12:33:04.335368 2017] m_xmlrpc: Tag name: methodCall, data:

[Apr 14 12:33:04.335415 2017] m_xmlrpc: Tag name: methodName, data: checkAuthentication
[Apr 14 12:33:04.335460 2017] m_xmlrpc: Tag name: /methodName, data:

[Apr 14 12:33:04.335504 2017] m_xmlrpc: Tag name: params, data:

[Apr 14 12:33:04.335548 2017] m_xmlrpc: Tag name: param, data:

[Apr 14 12:33:04.335594 2017] m_xmlrpc: Tag name: value, data:

[Apr 14 12:33:04.335647 2017] m_xmlrpc: Tag name: string, data: xlexious
[Apr 14 12:33:04.335685 2017] m_xmlrpc: Tag name: /string, data:

[Apr 14 12:33:04.335725 2017] m_xmlrpc: Tag name: string, data: <removed>
[Apr 14 12:33:04.335763 2017] m_xmlrpc: Tag name: /string, data:

[Apr 14 12:33:04.335801 2017] m_xmlrpc: Tag name: /value, data:

[Apr 14 12:33:04.335838 2017] m_xmlrpc: Tag name: /param, data:

[Apr 14 12:33:04.335875 2017] m_xmlrpc: Tag name: /params, data:

Notes
(0006845) Adam (administrator) 2017-07-25 01:38	Fixed in 3cb9e0b97c15e2d997d519b4bfc1821252c2384d

Issue History
Date Modified	Username	Field	Change
2017-04-14 11:38	Absolver	New Issue
2017-07-25 01:38	Adam	Note Added: 0006845
2017-07-25 01:38	Adam	Status	new => resolved
2017-07-25 01:38	Adam	Resolution	open => fixed
2017-07-25 01:38	Adam	Assigned To	=> Adam

Relationships