Anope Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001632Anope Stable (2.0.x series)[All Projects] Generalpublic2015-02-01 15:522015-03-12 14:16
Assigned ToAdam 
PlatformOSOS Version
Summary0001632: Email change confirmation lists old email rather than new.
DescriptionThe default data/example.conf has emailchange_message with "You have requested to change your email address to %e".

Then in SendConfirmMail in modules/commands/ns_set.cpp, we replace %e with the account's current email.

This results in a message being sent to the user claiming "You have requested to change your email address to (OLD EMAIL)", when instead that should be the new email. (The email is, however, correctly sent to the new email)

One possible fix is to replace %e with the new_email var instead. However, some users of Anope may have already assumed %e is the old email and written their emailchange_message accordingly. I think for compatibility it would be wiser to leave %e as is, and introduce a new variable, perhaps named %E, that contains the new email address.

I attached a patch (exported with `git format-patch`, so should be ready to `git am`) to that effect, or open to discussion on the matter. I can submit a PR on github too if that is preferred.
Steps To Reproduce/ns set email then check your email.
TagsNo tags attached.
Attached Filespatch file icon 0001-SendConfirmMail-Replace-E-with-new-email.patch [^] (2,124 bytes) 2015-02-01 15:52 [Show Content]

- Relationships

-  Notes
Adam (administrator)
2015-03-12 14:16

Applied in bf727285bcf7c7c95c2b2b43faa3d1fa13bad6fb, thanks.
ptseng (reporter)
2015-02-01 16:14

I believe the change in behavior was introduced in 1a3d9a016d3adc49788bbff73aac9b3b5ea85b17

- Issue History
Date Modified Username Field Change
2015-02-01 15:52 ptseng New Issue
2015-02-01 15:52 ptseng File Added: 0001-SendConfirmMail-Replace-E-with-new-email.patch
2015-02-01 16:14 ptseng Note Added: 0006694
2015-03-12 14:16 Adam Note Added: 0006719
2015-03-12 14:16 Adam Status new => resolved
2015-03-12 14:16 Adam Resolution open => fixed
2015-03-12 14:16 Adam Assigned To => Adam

Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker