View Issue Details

IDProjectCategoryView StatusLast Update
0001294Anope Development (1.9.x series)Nickservpublic2011-07-29 22:52
ReporterNita Assigned ToLEthaLity  
PriorityurgentSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinux x64OSDebian 
Fixed in Version1.9.x-GIT 
Summary0001294: Anope-1.9-f5e78d7 current devel crash: /msg NickServ SET HIDE EMAIL ON
DescriptionAnope-1.9-f5e78d7 current development crash:

/msg NickServ SET HIDE EMAIL ON
Crash (Tested with 3 different users)
Steps To Reproduce/msg NickServ SET HIDE EMAIL ON
Additional InformationInspircd 2.0.5
TagsNo tags attached.

Activities

LEthaLity

2011-07-29 22:52

manager   ~0005883

Fixed in f29c88bcd535e6dcf

LEthaLity

2011-07-29 19:37

manager  

ns_set_hide.diff (490 bytes)   
diff --git a/modules/core/ns_set_hide.cpp b/modules/core/ns_set_hide.cpp
index e1a9ecb..de3a96a 100644
--- a/modules/core/ns_set_hide.cpp
+++ b/modules/core/ns_set_hide.cpp
@@ -25,7 +25,7 @@ class CommandNSSetHide : public Command
 	void Run(CommandSource &source, const Anope::string &user, const Anope::string &param, const Anope::string &arg)
 	{
 		NickAlias *na = findnick(user);
-		if (user == NULL)
+		if (!na)
 		{
 			source.Reply(NICK_X_NOT_REGISTERED, user.c_str());
 			return;
ns_set_hide.diff (490 bytes)   

LEthaLity

2011-07-29 19:00

manager   ~0005882

Last edited: 2011-07-29 19:41

View 2 revisions

Confirmed, though I don't think it's limited to just HIDE EMAIL.
http://pastebin.com/BYxSpra8

Attached patch.

Issue History

Date Modified Username Field Change
2011-07-29 17:45 Nita New Issue
2011-07-29 19:00 LEthaLity Note Added: 0005882
2011-07-29 19:00 LEthaLity Status new => confirmed
2011-07-29 19:37 LEthaLity File Added: ns_set_hide.diff
2011-07-29 19:41 LEthaLity Note Edited: 0005882 View Revisions
2011-07-29 22:52 LEthaLity Note Added: 0005883
2011-07-29 22:52 LEthaLity Status confirmed => resolved
2011-07-29 22:52 LEthaLity Fixed in Version => 1.9.x-GIT
2011-07-29 22:52 LEthaLity Resolution open => fixed
2011-07-29 22:52 LEthaLity Assigned To => LEthaLity