View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001280Anope Development (1.9.x series)Nickservpublic2011-06-30 01:402011-10-30 02:38
ReporterNita Assigned ToAdam  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0001280: 1.9.5 current: "/msg NickServ SASET USER NOEXPIRE ON" does not write MD FLAG NOEXPIRE to anope.db
DescriptionWhen I use: /msg NickServ SASET USER NOEXPIRE ON
Service accepts my request, but after /msg OperServ UPDATE, there is no MD FLAG NOEXPIRE in anope.db

Noexpire works with ChanServ but does not work with NickServ.
Steps To Reproduce/msg NickServ SASET USER NOEXPIRE ON

anope.db:
NA USER
There is no: MD FLAGS NOEXPIRE
TagsNo tags attached.

Relationships

has duplicate 0001296 closedAdam NickServ NOEXPIRE lost on start/restart 

Activities

Adam

2011-07-04 19:27

administrator   ~0005853

Thanks, fixed in d6879c4a2568d487cf8fe9e4bf40fab3e7f87504

someone

2011-07-04 18:23

reporter  

0001-Fixed-NickAlias-NOEXPIRE-FLAG-not-being-written-to-p.patch (917 bytes)    
From 35bd17d6e9ff11a3ca25d208bbd15b3e2928eeb2 Mon Sep 17 00:00:00 2001
From: someone <someone@somenet.org>
Date: Mon, 4 Jul 2011 19:17:12 +0200
Subject: [PATCH] Fixed NickAlias NOEXPIRE-FLAG not being written to plain DB.

---
 modules/core/db_plain.cpp |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/modules/core/db_plain.cpp b/modules/core/db_plain.cpp
index 2396567..6086d49 100644
--- a/modules/core/db_plain.cpp
+++ b/modules/core/db_plain.cpp
@@ -745,6 +745,8 @@ class DBPlain : public Module
 			NickAlias *na = it->second;
 
 			db_buffer << "NA " << na->nc->display << " " << na->nick << " " << na->time_registered << " " << na->last_seen << endl;
+			if (na->HasFlag(NS_NO_EXPIRE))
+				db_buffer << "MD FLAGS NOEXPIRE" << endl;
 			if (!na->last_usermask.empty())
 				db_buffer << "MD LAST_USERMASK " << na->last_usermask << endl;
 			if (!na->last_realname.empty())
-- 
1.7.6
0001-Fixed-NickAlias-NOEXPIRE-FLAG-not-being-written-to-p.patch (917 bytes)   

someone

2011-07-04 18:23

reporter   ~0005851

this should be it. (more lines written in irc/here than code ;)

someone

2011-07-04 16:56

reporter   ~0005850

I can confirm that.

Issue History

Date Modified Username Field Change
2011-06-30 01:40 Nita New Issue
2011-07-04 16:56 someone Note Added: 0005850
2011-07-04 18:23 someone Note Added: 0005851
2011-07-04 18:23 someone File Added: 0001-Fixed-NickAlias-NOEXPIRE-FLAG-not-being-written-to-p.patch
2011-07-04 19:27 Adam Note Added: 0005853
2011-07-04 19:27 Adam Status new => resolved
2011-07-04 19:27 Adam Resolution open => fixed
2011-07-04 19:27 Adam Assigned To => Adam
2011-07-31 03:09 Adam Relationship added has duplicate 0001296