Anope Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001193Anope Stable (1.8.x series)NickServpublic2010-09-27 08:372010-09-29 00:40
Reporterdarkex 
Assigned ToAdam 
PrioritynormalSeverityminorReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001193: saset display -> nicktracking bug
DescriptionFlicking through the code of ns_saset.c one day, I stumbled across this:

    alog("%s: %s!%s@%s set the display of %s to: %s",
         s_NickServ, u->nick, u->username, u->host, nc->display, param);
    change_core_display(nc, param);
    notice_lang(s_NickServ, u, NICK_SASET_DISPLAY_CHANGED, nc->display);

    /* Enable nick tracking if enabled */
    if (NSNickTracking)
        nsStartNickTracking(u);

So we see the notice_lang is pointed at u which is the SA doing the saset. But we shouldn't be starting nicktracking for them. Not that it's much of a problem, but it's not meant to be tracking the SA but param instead.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0005633)
Adam (administrator)
2010-09-29 00:40

Thanks, should be fixed in commit 0383868a29b49defda92e56921189079448db6f5

- Issue History
Date Modified Username Field Change
2010-09-27 08:37 darkex New Issue
2010-09-29 00:40 Adam Note Added: 0005633
2010-09-29 00:40 Adam Status new => resolved
2010-09-29 00:40 Adam Resolution open => fixed
2010-09-29 00:40 Adam Assigned To => Adam


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker