0001269: install.js contains wrong path for MSVC++ 2010 for Windows 7

diff --git a/docs/WIN32.txt b/docs/WIN32.txt index a81f1ab..34e35e9 100644 --- a/docs/WIN32.txt +++ b/docs/WIN32.txt @@ -20,35 +20,41 @@ Anope for Windows * Current Anope source: http://sourceforge.net/project/showfiles.php?group_id=94081 - If you have Visual C++ 6, 7 (.NET 2002/2003) or 8 (2005) skip ahead to step 2, else you + If you have Visual C++ 6, 7 (.NET 2002/2003), 8 (2005) or 10 (2010) skip ahead to step 2, else you need to download the following free components from Microsoft. Once - downloaded, install these packages. + downloaded, install one of the following, for best results use MS VC 2010. - * Microsoft Visual C++ 2008 Express Edition: + * Microsoft Visual C++ 2010 Express http://www.microsoft.com/express/vc/ or - * Microsoft Visual C++ 2005 Express Edition: - http://msdn.microsoft.com/vstudio/express/visualc/download/ + * Microsoft Visual C++ 2008 Express Edition: + http://www.microsoft.com/visualstudio/en-us/products/2008-editions/express + + or + + * Microsoft Visual C++ 2005 Express Edition: + http://msdn.microsoft.com/vstudio/express/visualc/download/ - then download and install: + if you installed Visual C++ 2010, it comes included with an SDK, so skip ahead to step 2, otherwise + install the following PlatformSDK: - * Microsoft Windows PlatformSDK: (Requires WGA validation) - http://www.microsoft.com/downloads/details.aspx?FamilyId=0BAF2B35-C656-4969-ACE8-E4C0C0716ADB&displaylang=en + * Microsoft Windows PlatformSDK: (Requires WGA validation) + http://www.microsoft.com/downloads/details.aspx?FamilyId=0BAF2B35-C656-4969-ACE8-E4C0C0716ADB&displaylang=en - (NOTE: Although this says for Windows Server 2003, it does infact work on all supported - versions of Windows.) + (NOTE: Although this says for Windows Server 2003, it does infact work on all supported + versions of Windows.) - When installing, you should select the Custom option, and ensure that the top option relating to - the registering of environment varibales, is enabled in addition to the default selections. + When installing, you should select the Custom option, and ensure that the top option relating to + the registering of environment varibales, is enabled in addition to the default selections. - If you do not do this, you may run into problems with the PSDK not being found properly during install. + If you do not do this, you may run into problems with the PSDK not being found properly during install. - * MySQL for Windows (only needed if building with MySQL enabled): - http://dev.mysql.com/ + * MySQL for Windows (only needed if building with MySQL enabled): + http://dev.mysql.com/ - (NOTE: Anope can be compiled against MySQL Version 3.23 and above) + (NOTE: Anope can be compiled against MySQL Version 3.23 and above) 2) Unpack the Anope tarball with your favorite uncompression program diff --git a/install.js b/install.js index 93e586c..bd02fc0 100644 --- a/install.js +++ b/install.js @@ -74,15 +74,19 @@ var buildPackages = [ 'name' : 'Microsoft Visual Studio 2010 (64bit)', 'libpaths' : [ 'Program Files (x86)\\Microsoft Visual Studio 10.0\\VC\\lib', - 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\Lib' + 'Program Files\\Microsoft SDKs\\Windows\\v7.1\\Lib', + 'Program Files\\Microsoft SDKs\\Windows\\v7.0\\Lib', + 'Program Files (x86)\\Microsoft SDKs\\Windows\\v7.0A\\Lib' ], 'incpaths': [ 'Program Files (x86)\\Microsoft Visual Studio 10.0\\VC\\include', - 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\include' - ], + 'Program Files\\Microsoft SDKs\\Windows\\v7.1\\Include', + 'Program Files\\Microsoft SDKs\\Windows\\v7.0\\Include', + 'Program Files (x86)\\Microsoft SDKs\\Windows\\v7.0A\\Include' + ], 'nmake' : [ - 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\Bin', - ], + 'Program Files (x86)\\Microsoft Visual Studio 10.0\\VC\\bin', + ], 'additional_switches' : [ '/w' ], 'installedDrive' : 'C' }, @@ -90,14 +94,18 @@ var buildPackages = [ 'name' : 'Microsoft Visual Studio 2010', 'libpaths' : [ 'Program Files\\Microsoft Visual Studio 10.0\\VC\\lib', - 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\Lib' + 'Program Files\\Microsoft SDKs\\Windows\\v7.1\\Lib', + 'Program Files\\Microsoft SDKs\\Windows\\v7.0\\Lib', + 'Program Files\\Microsoft SDKs\\Windows\\v7.0A\\Lib' ], 'incpaths' : [ 'Program Files\\Microsoft Visual Studio 10.0\\VC\\include', - 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\Include' + 'Program Files\\Microsoft SDKs\\Windows\\v7.1\\Include', + 'Program Files\\Microsoft SDKs\\Windows\\v7.0\\Include', + 'Program Files\\Microsoft SDKs\\Windows\\v7.0A\\Include' ], 'nmake' : [ - 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\Bin', + 'Program Files\\Microsoft Visual Studio 10.0\\VC\\bin', ], 'additional_switches' : [ '/w' ], 'installedDrive' : 'C' @@ -113,7 +121,7 @@ var buildPackages = [ 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\Include' ], 'nmake' : [ - 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\Bin', + 'Program Files\\Microsoft Platform SDK for Windows Server 2003 R2\\Bin', ], 'additional_switches' : [ '/w' ], 'installedDrive' : 'C'

Notes
(0005881) LEthaLity (manager) 2011-07-28 18:25	Fixed (hopefully) in commit 8007cc8a3a162d

(0005880) LEthaLity (manager) 2011-07-28 17:16 edited on: 2011-07-28 17:18	Included possible patch to fix this issue (http://lethality.me.uk/patches/windows7fix.diff [^] ignore the docs/win32 stuff), works for me on my pc and laptop, both running Windows 7 with vs c++ 2010. Worth noting that c++ 2010 does come with Windows 7 SDK v7.0A included, the proposed fix now checks for 7.1, 7.0A, 7.0. Looking for a suitable compiler... Looking for: Microsoft Visual Studio 2010 (64bit)... SUCCESS: Microsoft Visual Studio 2010 (64bit) was found, and is complete! Build tools were found successfully! Anope will be compiled with the following options: MySQL DB Support: [NO] Compiler Version: Microsoft Visual Studio 2010 (64bit) MySQLDB Version: Not Enabled Anope Version: 1.8.6.3072

(0005832) Adam (administrator) 2011-05-24 23:43	On 32-bit Windows 7 with VS2010 this affects me too, however my path needs to be Program Files\Microsoft Platform SDK\

(0005825) katsklaw (reporter) 2011-05-18 02:12	Grrr, sorry. It doesn't contain the wrong path for MSVC++ '10, but for the SDK package that Windows 7 uses. Granted, XP can use the '03 SDK but Windows 7 doesn't, so to compile on Windows 7 you have to have the Windows SDKs found at: http://www.microsoft.com/downloads/dlx/en-us/listdetailsview.aspx?FamilyID=6b6c21d2-2006-4afa-9702-529fa782d63b [^]

(0005824) katsklaw (reporter) 2011-05-15 19:11	This bug refers to Anope-1.8.6

Issue History
Date Modified	Username	Field	Change
2011-05-15 19:10	katsklaw	New Issue
2011-05-15 19:11	katsklaw	Note Added: 0005824
2011-05-18 02:12	katsklaw	Note Added: 0005825
2011-05-24 23:43	Adam	Note Added: 0005832
2011-05-24 23:44	Adam	Assigned To	=> therock247uk
2011-05-24 23:44	Adam	Status	new => acknowledged
2011-07-28 17:16	LEthaLity	Note Added: 0005880
2011-07-28 17:17	LEthaLity	File Added: windows7fix.diff
2011-07-28 17:18	LEthaLity	Note Edited: 0005880	View Revisions
2011-07-28 17:18	LEthaLity	Note Edited: 0005880	View Revisions
2011-07-28 17:19	LEthaLity	Status	acknowledged => confirmed
2011-07-28 18:25	LEthaLity	Note Added: 0005881
2011-07-28 18:25	LEthaLity	Status	confirmed => resolved
2011-07-28 18:25	LEthaLity	Fixed in Version	=> GIT (include a /version response in report)
2011-07-28 18:25	LEthaLity	Resolution	open => fixed

Relationships