Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001264DenoraProtocolpublic2011-04-18 22:112012-07-18 13:13
Reporterjobe 
Assigned Tojobe 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.5.0-git 
Target Version1.5.0-gitFixed in Version1.5.0-git 
Summary0001264: Remote OPER (Nefarious) causes double oper counting
DescriptionSummary says it all but basically the MODE sent out to remotely change a users mode, followed by the reply of the user setting the mode results in 2 identical +o's for the same user making the opers count increment twice.

Suggested fix, ignored MODE (M) where source == server and target == user.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0006216)
OUTsider (developer)
2012-07-17 17:28

Check if fixed in current git: http://git.io/K-IkKg [^]
(0006191)
OUTsider (developer)
2012-07-15 14:40

nope, it won't. But your issue is in handle_ircop which is called upon EVERY usermode o change, not your protocol. see src/main.c:1359
(0006190)
OUTsider (developer)
2012-07-15 14:28

I added a simple test in handle_ircop to check for the previous state of the client. If he's not oper already, don't add, and if he's not oper anyways, don't deduct.

Please check if this solves your issue

- Issue History
Date Modified Username Field Change
2011-04-18 22:11 jobe New Issue
2011-04-18 22:11 jobe Status new => assigned
2011-04-18 22:11 jobe Assigned To => jobe
2012-07-15 14:28 OUTsider Note Added: 0006190
2012-07-15 14:40 OUTsider Note Added: 0006191
2012-07-15 14:40 OUTsider Status assigned => acknowledged
2012-07-17 17:28 OUTsider Note Added: 0006216
2012-07-17 17:28 OUTsider Status acknowledged => feedback
2012-07-18 13:13 OUTsider Status feedback => resolved
2012-07-18 13:13 OUTsider Fixed in Version => 1.5.0-git
2012-07-18 13:13 OUTsider Resolution open => fixed


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker