Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001170DenoraProtocolpublic2010-06-08 09:472010-07-11 12:45
Reporterjobe 
Assigned ToHal9000 
PrioritynormalSeverityminorReproducibilityalways
StatusassignedResolutionfixed 
Platformx86OSFreeBSDOS Version7.0
Product Version1.4.5-SVN 
Target VersionFixed in Version1.4.5-SVN 
Summary0001170: Denora not respecting mode parsing rules
DescriptionOK basically Denora does nto currently appear to respect IRCd specific rules regarding whether or not mode params are needed to unset modes when parsing channel modes.

For example Nefarious does not require a param to unset +L or +l, however denora behaves as if both do.

From what I can see the same also appears to be true for other IRCd's too but I am at present unable to test.

An example of how this can be a problem is if for example a user sets channel mode "-le exception!mask@*" then Denora will pass the mask as the param for +l and ignore +e due to missing param.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0005452)
jobe (developer)
2010-07-11 12:45

[Jul 11 12:43:54.135996 2010] debug: Received: IAAHY M #Jobe -Le bob!*@*
[Jul 11 12:43:54.146853 2010] debug: Changing modes for #jobe to -Le bob!*@*
[Jul 11 12:43:54.146937 2010] debug: Deleted except bob!*@* from channel #jobe

Evidence enough for you? :P
(0005451)
Hal9000 (administrator)
2010-07-10 22:21

oh, really?
(0005449)
jobe (developer)
2010-07-10 22:12

Currently fixed in r361
(0005446)
jobe (developer)
2010-07-04 12:34
edited on: 2010-07-04 12:37

It's certainly not fixed. If anything it's worse now. :/

[Jul 04 12:30:39.031842 2010] debug: Received: IAAAI M #Jobe +Le #bob bob!*@*
[Jul 04 12:30:39.032093 2010] debug: Changing modes for #jobe to +Le #bob bob!*@*
[Jul 04 12:30:39.032184 2010] debug: Added except #bob to channel #jobe

[Jul 04 12:31:18.489896 2010] debug: Received: IAAAI M #Jobe -Le bob!*@*
[Jul 04 12:31:18.490113 2010] debug: Changing modes for #jobe to -Le bob!*@*
[Jul 04 12:31:18.490208 2010] debug: Deleted except bob!*@* from channel #jobe


And after both, the MySQL lists "#bob" as an existing exempt despite there being none. Additionally it seemed to ignore the fact +L has a param to SET as well, so took #bob as an except instead of +L's param.

(0005440)
Hal9000 (administrator)
2010-07-03 11:19

i believe this has been fixed in revision 359. please test and let me know :)

- Issue History
Date Modified Username Field Change
2010-06-08 09:47 jobe New Issue
2010-07-03 11:19 Hal9000 Note Added: 0005440
2010-07-03 11:57 Hal9000 Status new => resolved
2010-07-03 11:57 Hal9000 Fixed in Version => 1.4.5-SVN
2010-07-03 11:57 Hal9000 Resolution open => fixed
2010-07-03 11:57 Hal9000 Assigned To => Hal9000
2010-07-04 12:34 jobe Note Added: 0005446
2010-07-04 12:34 jobe Status resolved => feedback
2010-07-04 12:34 jobe Resolution fixed => reopened
2010-07-04 12:35 jobe Note Edited: 0005446 View Revisions
2010-07-04 12:37 jobe Note Edited: 0005446 View Revisions
2010-07-10 22:12 jobe Note Added: 0005449
2010-07-10 22:12 jobe Status feedback => assigned
2010-07-10 22:13 jobe Resolution reopened => fixed
2010-07-10 22:21 Hal9000 Note Added: 0005451
2010-07-11 12:45 jobe Note Added: 0005452


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker